Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source control release process #112

Merged
merged 7 commits into from
Mar 7, 2023
Merged

Source control release process #112

merged 7 commits into from
Mar 7, 2023

Conversation

sophia-guo
Copy link
Contributor

Move release job setting and code to git repo
Only upload test results for releases

Fix #111

Signed-off-by: Sophia Guo sophia.gwf@gmail.com

@sophia-guo sophia-guo marked this pull request as draft March 1, 2023 21:41
@sophia-guo
Copy link
Contributor Author

Need to double check the correct of way to set password parameter GITHUB_TOKEN

@sophia-guo sophia-guo requested a review from gdams March 3, 2023 20:51
@sophia-guo sophia-guo marked this pull request as ready for review March 3, 2023 20:51
@sophia-guo
Copy link
Contributor Author

Note, when update the job configuration parameter UPLOAD_TAPS_ONLY need to explicate removed, which is renamed to UPLOAD_TESTRESULTS_ONLY

Move release job setting and code to git repo
Only upload test results for releases

Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karianna karianna merged commit 3da9cb4 into adoptium:master Mar 7, 2023
@sxa
Copy link
Member

sxa commented Mar 23, 2023

Note: Path to releaseCheck.sh in here was incorrect, fixed in #122

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

@gdams
Copy link
Member

gdams commented May 7, 2024

@sophia-guo did this ever get put into production? Looking at the refactor release job it still seems to be manually defined?

@sophia-guo
Copy link
Contributor Author

I setup a new job and tested, should be good to go though has not be put into production https://ci.adoptium.net/view/all/job/refactor_openjdk_release_tool_new/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving release process code to git repo
5 participants